lkml.org 
[lkml]   [2021]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: usb: midi: don't return -ENOMEM when usb_urb_ep_type_check fails
On Tue, 20 Apr 2021 15:47:19 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when the call to usb_urb_ep_type_check fails (returning -EINVAL)
> the error return path returns -ENOMEM via the exit label "error". Other
> uses of the same error exit label set the err variable to -ENOMEM but this
> is not being used. I believe the original intent was for the error exit
> path to return the value in err rather than the hard coded -ENOMEM, so
> return this rather than the hard coded -ENOMEM.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 738d9edcfd44 ("ALSA: usb-audio: Add sanity checks for invalid EPs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.


Takashi

\
 
 \ /
  Last update: 2021-04-20 17:01    [W:0.044 / U:5.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site