lkml.org 
[lkml]   [2021]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] powerpc/pseries/iommu: Fix window size for direct mapping with pmem
From
Date
On Tue, 2021-04-20 at 15:18 +1000, Alexey Kardashevskiy wrote:
>
> On 20/04/2021 14:54, Leonardo Bras wrote:
> > As of today, if the DDW is big enough to fit (1 << MAX_PHYSMEM_BITS) it's
> > possible to use direct DMA mapping even with pmem region.
> >
> > But, if that happens, the window size (len) is set to
> > (MAX_PHYSMEM_BITS - page_shift) instead of MAX_PHYSMEM_BITS, causing a
> > pagesize times smaller DDW to be created, being insufficient for correct
> > usage.
> >
> > Fix this so the correct window size is used in this case.
>
> Good find indeed.
>
> afaict this does not create a huge problem though as
> query.largest_available_block is always smaller than (MAX_PHYSMEM_BITS -
> page_shift) where it matters (phyp).
>
>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>

Thanks for reviewing!

Leonardo Bras

\
 
 \ /
  Last update: 2021-04-20 07:31    [W:0.049 / U:5.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site