Messages in this thread | | | Date | Fri, 2 Apr 2021 09:47:20 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor() |
| |
> + if (!pmd) > + return dax_load_hole(xas, mapping, &entry, vmf); > + else > + return dax_pmd_load_hole(xas, vmf, iomap, &entry);
> + if (pmd) > + return vmf_insert_pfn_pmd(vmf, pfn, write); > + if (write) > + return vmf_insert_mixed_mkwrite(vmf->vma, vmf->address, pfn); > + else > + return vmf_insert_mixed(vmf->vma, vmf->address, pfn); > +}
No need for else statements after returning.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |