Messages in this thread | | | Subject | Re: [PATCH] mwifiex: don't print SSID to logs | From | Kalle Valo <> | Date | Sat, 17 Apr 2021 17:47:06 +0000 (UTC) |
| |
Brian Norris <briannorris@chromium.org> wrote:
> There are a few reasons not to dump SSIDs as-is in kernel logs: > > 1) they're not guaranteed to be any particular text encoding (UTF-8, > ASCII, ...) in general > 2) it's somewhat redundant; the BSSID should be enough to uniquely > identify the AP/STA to which we're connecting > 3) BSSIDs have an easily-recognized format, whereas SSIDs do not (they > are free-form) > 4) other common drivers (e.g., everything based on mac80211) get along > just fine by only including BSSIDs when logging state transitions > > Additional notes on reason #3: this is important for the > privacy-conscious, especially when providing tools that convey > kernel logs on behalf of a user -- e.g., when reporting bugs. So for > example, it's easy to automatically filter logs for MAC addresses, but > it's much harder to filter SSIDs out of unstructured text. > > Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
d23a96220353 mwifiex: don't print SSID to logs
-- https://patchwork.kernel.org/project/linux-wireless/patch/20210225024454.4106485-1-briannorris@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |