Messages in this thread | | | Date | Sat, 17 Apr 2021 12:50:28 +0100 | From | Khaled Romdhani <> | Subject | Re: [PATCH-next] fs/btrfs: Fix uninitialized variable |
| |
On Fri, Apr 16, 2021 at 07:32:03PM +0200, David Sterba wrote: > On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote: > > The variable zone is not initialized. It > > may causes a failed assertion. > > Failed assertion means the 2nd one checking that the result still fits > to 32bit type. That would mean that none of the cases were hit, but all > callers pass valid values. > > It would be better to add a default: case to catch that explicitly, > though hitting that is considered 'will not happen'.
Yes. I will send a V2.
| |