Messages in this thread | | | Date | Fri, 16 Apr 2021 20:33:36 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: core: Constify buf in mtd_write_user_prot_reg() |
| |
Hi Tudor,
Tudor Ambarus <tudor.ambarus@microchip.com> wrote on Sat, 3 Apr 2021 09:09:31 +0300:
> The write buffer comes from user and should be const. > Constify write buffer in mtd core and across all _write_user_prot_reg() > users. cfi_cmdset_{0001, 0002} and onenand_base will pay the cost of an > explicit cast to discard the const qualifier since the beginning, since > they are using an otp_op_t function prototype that is used for both reads > and writes. mtd_dataflash and SPI NOR will benefit of the const buffer > because they are using different paths for writes and reads. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied on top of mtd/next after the merge of all our internal PR's.
Thanks, Miquèl
| |