Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH 3/5] dt-bindings: mtd: add OTP bindings | Date | Fri, 16 Apr 2021 13:30:01 -0500 |
| |
On Fri, 16 Apr 2021 13:49:26 +0200, Michael Walle wrote: > Flash devices can have one-time-programmable regions. Add a nvmem > binding so they can be used as a nvmem provider. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > Changes since RFC: > - added missing "$" > - dropped first example > - use real device compatibles > > Please note, that this will lead to an error without patch 4/5, which > introduces that property for the jedec,spi-nor. Should I keep it > seperate or should I squash that patch into this one? > > .../devicetree/bindings/mtd/mtd.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/mtd.example.dt.yaml: flash@0: 'otp-1', 'otp-2' do not match any of the regexes: '^partition@', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
See https://patchwork.ozlabs.org/patch/1467024
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |