lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 21/57] staging: iio: frequency: ad9834: Provide missing description for 'devid'
    On Wed, 14 Apr 2021 19:10:53 +0100
    Lee Jones <lee.jones@linaro.org> wrote:

    > Also demote kernel-doc abuses
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/staging/iio/frequency/ad9834.c:87: warning: Function parameter or member 'devid' not described in 'ad9834_state'
    > drivers/staging/iio/frequency/ad9834.c:93: warning: cannot understand function prototype: 'enum ad9834_supported_device_ids '
    > drivers/staging/iio/frequency/ad9834.c:320: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    >
    > Cc: Lars-Peter Clausen <lars@metafoo.de>
    > Cc: Michael Hennerich <Michael.Hennerich@analog.com>
    > Cc: Jonathan Cameron <jic23@kernel.org>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: linux-iio@vger.kernel.org
    > Cc: linux-staging@lists.linux.dev
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    I was leaving the staging stuff in IIO related to W=1 as good material
    for newbies, but I guess if you are blanket cleaning it up then fair
    enough.

    Sounds like Greg will take the whole series so,

    Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    > ---
    > drivers/staging/iio/frequency/ad9834.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
    > index 60a3ae5587b90..94b131ef8a22c 100644
    > --- a/drivers/staging/iio/frequency/ad9834.c
    > +++ b/drivers/staging/iio/frequency/ad9834.c
    > @@ -58,6 +58,7 @@
    > * @spi: spi_device
    > * @mclk: external master clock
    > * @control: cached control word
    > + * @devid: device id
    > * @xfer: default spi transfer
    > * @msg: default spi message
    > * @freq_xfer: tuning word spi transfer
    > @@ -86,7 +87,7 @@ struct ad9834_state {
    > __be16 freq_data[2];
    > };
    >
    > -/**
    > +/*
    > * ad9834_supported_device_ids:
    > */
    >
    > @@ -316,7 +317,7 @@ ssize_t ad9834_show_out1_wavetype_available(struct device *dev,
    > static IIO_DEVICE_ATTR(out_altvoltage0_out1_wavetype_available, 0444,
    > ad9834_show_out1_wavetype_available, NULL, 0);
    >
    > -/**
    > +/*
    > * see dds.h for further information
    > */
    >

    \
     
     \ /
      Last update: 2021-04-16 19:31    [W:4.515 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site