Messages in this thread | | | Subject | Re: [PATCH v2] uml: fix W=1 missing-include-dirs warnings | From | Anton Ivanov <> | Date | Fri, 16 Apr 2021 07:11:43 +0100 |
| |
On 15/04/2021 18:13, Randy Dunlap wrote: > Currently when using "W=1" with UML builds, there are over 700 warnings > like so: > > CC arch/um/drivers/stderr_console.o > cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] > > but arch/um/ does not have include/uapi/ at all, so add that > subdir and put one Kbuild file into it (since git does not track > empty subdirs). > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Michal Marek <michal.lkml@markovi.net> > Cc: linux-kbuild@vger.kernel.org > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: linux-um@lists.infradead.org > --- > v2: use Option 4 from v1: add arch/um/include/uapi so that 'make' is > placated -- and just like all other arch's have. > > arch/um/include/uapi/asm/Kbuild | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/um/include/uapi/asm/Kbuild b/arch/um/include/uapi/asm/Kbuild > new file mode 100644 > index 000000000000..f66554cd5c45 > --- /dev/null > +++ b/arch/um/include/uapi/asm/Kbuild > @@ -0,0 +1 @@ > +# SPDX-License-Identifier: GPL-2.0 > > _______________________________________________ > linux-um mailing list > linux-um@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-um > +1
I will forward it to openwrt-dev. Their build process adds uapi to uml, so if we are going to change this, it will be nice to give them a heads-up.
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
-- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/
| |