Messages in this thread | | | Date | Fri, 16 Apr 2021 17:22:46 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH v2 1/2] iommu: Statically set module owner |
| |
On Thu, Apr 01, 2021 at 02:56:25PM +0100, Robin Murphy wrote: > It happens that the 3 drivers which first supported being modular are > also ones which play games with their pgsize_bitmap, so have non-const > iommu_ops where dynamically setting the owner manages to work out OK. > However, it's less than ideal to force that upon all drivers which want > to be modular - like the new sprd-iommu driver which now has a potential > bug in that regard - so let's just statically set the module owner and > let ops remain const wherever possible. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Will Deacon <will@kernel.org> > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + > drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 + > drivers/iommu/sprd-iommu.c | 1 + > drivers/iommu/virtio-iommu.c | 1 + > include/linux/iommu.h | 9 +-------- > 5 files changed, 5 insertions(+), 8 deletions(-)
Applied these two directly on-top of my next branch. This essentially means that all topic branches are frozen now until after the merge window.
Regards,
Joerg
| |