Messages in this thread | | | Date | Fri, 16 Apr 2021 11:20:49 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH v2 5/8] mm: memcontrol: rename lruvec_holds_page_lru_lock to page_matches_lruvec |
| |
On Fri, Apr 16, 2021 at 01:14:04PM +0800, Muchun Song wrote: > lruvec_holds_page_lru_lock() doesn't check anything about locking and is > used to check whether the page belongs to the lruvec. So rename it to > page_matches_lruvec(). > > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
The rename makes sense, since the previous name was defined by a specific use case rather than what it does. That said, it did imply a lock context that makes the test result stable. Without that the function could use a short comment, IMO. How about:
/* Test requires a stable page->memcg binding, see page_memcg() */
With that, Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |