lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: Fixes tag needs some work in the kvm tree
From
Date


On 16.04.21 16:58, Stephen Rothwell wrote:
> Hi all,
>
> On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 16/04/21 14:38, Christian Borntraeger wrote:
>>> On 16.04.21 14:27, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
>>>>
>>>> Fixes tag
>>>>
>>>>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
>>>>
>>>> has these problem(s):
>>>>
>>>>    - Subject does not match target commit subject
>>>>      Just use
>>>>     git log -1 --format='Fixes: %h ("%s")'
>>>
>>> Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
>>>
>>
>> Maybe you just missed it when it was reported for kvms390?
>>
>> https://www.spinics.net/lists/linux-next/msg59652.html
>
> It was a different commit SHA then and was reported because the Fixes
> SHA did not exist. It was fixed the next day, so I guess either I
> missed reporting this different problem, or I thought at least it had
> been fixed to use the correct SHA. I am not completely consistent,
> sometimes :-)

Yeah, seems that my fix was only half-way correct then but it managed to get past your review.

\
 
 \ /
  Last update: 2021-04-16 17:11    [W:0.038 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site