Messages in this thread | | | Subject | Re: [PATCH] floppy: remove redundant assignment to variable st | From | Denis Efremov <> | Date | Fri, 16 Apr 2021 15:29:01 +0300 |
| |
Jens, could you please take this one? I thought to send it to you with other cleanup patches in a merge request, but you already applied rest of the patches. If you prefer to take it as merge request, it's ok I'll send it based on your branch for-5.13/drivers.
On 4/15/21 4:00 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable st is being assigned a value that is never read and > it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Denis Efremov <efremov@linux.com>
Thanks, Denis
> --- > arch/x86/include/asm/floppy.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h > index d43717b423cb..6ec3fc969ad5 100644 > --- a/arch/x86/include/asm/floppy.h > +++ b/arch/x86/include/asm/floppy.h > @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id) > int lcount; > char *lptr; > > - st = 1; > for (lcount = virtual_dma_count, lptr = virtual_dma_addr; > lcount; lcount--, lptr++) { > st = inb(virtual_dma_port + FD_STATUS); >
| |