lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] coresight: Add support for device names
On 2021-04-16 19:19, Alexander Shishkin wrote:
> Tao Zhang <taozha@codeaurora.org> writes:
>
>> diff --git a/drivers/hwtracing/coresight/coresight-core.c
>> b/drivers/hwtracing/coresight/coresight-core.c
>> index 4ba801d..b79c726 100644
>> --- a/drivers/hwtracing/coresight/coresight-core.c
>> +++ b/drivers/hwtracing/coresight/coresight-core.c
>> @@ -1640,6 +1640,12 @@ char *coresight_alloc_device_name(struct
>> coresight_dev_list *dict,
>> int idx;
>> char *name = NULL;
>> struct fwnode_handle **list;
>> + struct device_node *node = dev->of_node;
>> +
>> + if (!node) {
>> + if (!of_property_read_string(node, "coresight-name", &name))
>
> Ok, I'm not a device tree expert, but I'm pretty sure the above is a
> nop.
>
> Regards,
> --
> Alex
You are right. The pointer check code here is wrong, I will correct it
on the V2 version.

Tao

\
 
 \ /
  Last update: 2021-04-16 14:15    [W:0.041 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site