Messages in this thread | | | Subject | Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler | From | Alex Elder <> | Date | Fri, 16 Apr 2021 07:12:10 -0500 |
| |
On 4/15/21 10:40 PM, zhuguangqing83@gmail.com wrote: > From: Guangqing Zhu <zhuguangqing83@gmail.com>
This is not required here. -Alex
https://lore.kernel.org/netdev/d57e0a43-4d87-93cf-471c-c8185ea85ced@ieee.org/
> Coccinelle noticed: > drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com> > --- > drivers/net/ipa/ipa_smp2p.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c > index a5f7a79a1923..74e04427a711 100644 > --- a/drivers/net/ipa/ipa_smp2p.c > +++ b/drivers/net/ipa/ipa_smp2p.c > @@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, > } > irq = ret; > > - ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p); > + ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT, > + name, smp2p); > if (ret) { > dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name); > return ret; >
| |