lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors
From
Date

Hi Calvin,

Thanks for the feedback. I'll begin making the change and testing. I'll
respond with V2 patch in this thread.

Regards,
Terry


On 4/14/21 9:13 PM, Calvin Walton wrote:
> On Tue, 2021-03-30 at 21:38 +0000, Terry Bowman wrote:
>> +int idx_valid_amd(int idx)
>> +{
>> +       switch (idx) {
>> +       case IDX_PKG_ENERGY:
>> +               return do_rapl & MSR_PKG_ENERGY_STAT;
> This isn't correct - MSR_PKG_ENERGY_STAT is the MSR offset, not a bit
> mask for the do_rapl bit field.
>
> The presence of MSR_PKG_ENERGY_STAT (along with MSR_RAPL_PWR_UNIT and
> MSR_CORE_ENERGY_STAT) is indicated by the RAPL_AMD_F17H bit in do_rapl,
> and can be checked with:
> do_rapl & RAPL_AMD_F17H
>
>

\
 
 \ /
  Last update: 2021-04-16 13:43    [W:0.067 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site