lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: seq: oss: Fix inconsistent indenting
On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
>
> Kernel test robot throws below warning ->
>
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
>
> Fixed the inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> sound/core/seq/oss/seq_oss_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
> /* set volume to zero -- note off */
> // type = SNDRV_SEQ_EVENT_NOTEOFF;
> //else
> - if (info->ch[ch].vel)
> + if (info->ch[ch].vel)
> /* sample already started -- volume change */
> type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi

\
 
 \ /
  Last update: 2021-04-16 12:43    [W:0.069 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site