Messages in this thread | | | Subject | Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use | From | Joe Perches <> | Date | Fri, 16 Apr 2021 17:09:21 -0700 |
| |
On Fri, 2021-04-16 at 14:41 -0600, Khalid Aziz wrote: > On 4/15/21 8:08 PM, Joe Perches wrote: > > And while it's a lot more code, I'd prefer a solution that looks more > > like the other commonly used kernel logging extension mechanisms > > where adapter is placed before the format, ... in the argument list. > > Hi Joe, > > I don't mind making these changes. It is quite a bit of code but > consistency with other kernel code is useful. Would you like to finalize > this patch, or would you prefer that I take this patch as starting point > and finalize it?
Probably better to apply Maciej's patches first and then something like this.
btw: the coccinelle script was
@@ expression a, b; @@
\(blogic_announce\|blogic_info\|blogic_notice\|blogic_warn\|blogic_err\)( - a, b + b, a , ...)
| |