lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 1/6] w1: ds2438: fixed a coding style issue
    Date
    There is an if statement and, if the function goes into it, it returns. So,
    the next else is not required.

    Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
    ---
    drivers/w1/slaves/w1_ds2438.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c
    index 5cfb0ae23e91..148921fb9702 100644
    --- a/drivers/w1/slaves/w1_ds2438.c
    +++ b/drivers/w1/slaves/w1_ds2438.c
    @@ -154,11 +154,11 @@ static int w1_ds2438_change_config_bit(struct w1_slave *sl, u8 mask, u8 value)

    if ((status & mask) == value)
    return 0; /* already set as requested */
    - else {
    - /* changing bit */
    - status ^= mask;
    - perform_write = 1;
    - }
    +
    + /* changing bit */
    + status ^= mask;
    + perform_write = 1;
    +
    break;
    }

    --
    2.30.1
    \
     
     \ /
      Last update: 2021-04-17 00:17    [W:9.315 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site