lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH v3 2/2] staging: rtl8723bs: Remove everything related with LedBlink
On Wed, Apr 14, 2021 at 09:27:50PM +0200, Fabio M. De Francesco wrote:
> Removed struct LedBlink_param. Removed LedBlink entries in
> rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is
> not anymore needed. Removed extra blank lines in the two mentioned
> arrays and changend the numbers set in comments for having them in line
> with the shift.
>
> Reported-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>
> Changes from v2: Added this patch as 2/2.
> Changes from v1: No changes.
>
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 27 ++++++---------------
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 14 +++--------
> 2 files changed, 11 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index f82dbd4f4c3d..a74e6846f2df 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -22,7 +22,6 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> {GEN_CMD_CODE(_Write_EEPROM), NULL},
> {GEN_CMD_CODE(_Read_EFUSE), NULL},
> {GEN_CMD_CODE(_Write_EFUSE), NULL},
> -
> {GEN_CMD_CODE(_Read_CAM), NULL}, /*10*/
> {GEN_CMD_CODE(_Write_CAM), NULL},
> {GEN_CMD_CODE(_setBCNITV), NULL},

These blank lines are there for a reason, please do not remove them.

thanks,

gre gk-h

\
 
 \ /
  Last update: 2021-04-15 08:19    [W:0.051 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site