lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 01/18] interconnect: core: fix error return code of icc_link_destroy()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    [ Upstream commit 715ea61532e731c62392221238906704e63d75b6 ]

    When krealloc() fails and new is NULL, no error return code of
    icc_link_destroy() is assigned.
    To fix this bug, ret is assigned with -ENOMEM hen new is NULL.

    Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Link: https://lore.kernel.org/r/20210306132857.17020-1-baijiaju1990@gmail.com
    Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/interconnect/core.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
    index c498796adc07..e579b3633a84 100644
    --- a/drivers/interconnect/core.c
    +++ b/drivers/interconnect/core.c
    @@ -704,6 +704,8 @@ int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
    GFP_KERNEL);
    if (new)
    src->links = new;
    + else
    + ret = -ENOMEM;

    out:
    mutex_unlock(&icc_lock);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-04-15 17:09    [W:4.092 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site