lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 15/38] gianfar: Handle error code at MAC address change
    Date
    From: Claudiu Manoil <claudiu.manoil@nxp.com>

    [ Upstream commit bff5b62585123823842833ab20b1c0a7fa437f8c ]

    Handle return error code of eth_mac_addr();

    Fixes: 3d23a05c75c7 ("gianfar: Enable changing mac addr when if up")
    Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/gianfar.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
    index bc00fa5e864f..fb135797688a 100644
    --- a/drivers/net/ethernet/freescale/gianfar.c
    +++ b/drivers/net/ethernet/freescale/gianfar.c
    @@ -485,7 +485,11 @@ static struct net_device_stats *gfar_get_stats(struct net_device *dev)

    static int gfar_set_mac_addr(struct net_device *dev, void *p)
    {
    - eth_mac_addr(dev, p);
    + int ret;
    +
    + ret = eth_mac_addr(dev, p);
    + if (ret)
    + return ret;

    gfar_set_mac_for_addr(dev, 0, dev->dev_addr);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-04-15 16:51    [W:4.102 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site