lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 37/57] staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers into the heap
    I screwed up my last email and dropped Lee and Arnd from the To: headers.
    Resending.

    On Thu, Apr 15, 2021 at 08:20:16AM +0300, Dan Carpenter wrote:
    > On Wed, Apr 14, 2021 at 07:11:09PM +0100, Lee Jones wrote:
    > > ---
    > > drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +++++++++++-
    > > 1 file changed, 11 insertions(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
    > > index c95ae4d6a3b6b..cc14f00947781 100644
    > > --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
    > > +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
    > > @@ -224,7 +224,7 @@ static char *translate_scan(struct adapter *padapter,
    > > /* parsing WPA/WPA2 IE */
    > > {
    > > u8 *buf;
    > > - u8 wpa_ie[255], rsn_ie[255];
    > > + u8 *wpa_ie, *rsn_ie;
    > > u16 wpa_len = 0, rsn_len = 0;
    > > u8 *p;
    > >
    > > @@ -232,6 +232,14 @@ static char *translate_scan(struct adapter *padapter,
    > > if (!buf)
    > > return start;

    Arnd added this return. I think it should be -ENOMEM, though?

    > >
    > > + wpa_ie = kzalloc(255, GFP_ATOMIC);
    > > + if (!wpa_ie)
    > > + return start;
    >
    > kfree(buf);
    >
    > > +
    > > + rsn_ie = kzalloc(255, GFP_ATOMIC);
    > > + if (!rsn_ie)
    > > + return start;
    >

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2021-04-15 07:54    [W:4.731 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site