Messages in this thread | | | Date | Thu, 15 Apr 2021 15:41:23 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [Outreachy kernel] Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code |
| |
> > > +#define ZR36057_JMC_JPG_EXP_MODE (0 << 29) > > > +#define ZR36057_JMC_JPG_CMP_MODE BIT(29) > > > +#define ZR36057_JMC_MJPG_EXP_MODE (2 << 29) > > > +#define ZR36057_JMC_MJPG_CMP_MODE (3 << 29) > > Same as above. Please change back ZR36057_JMC_JPG_CMP_MODE to be (1 << 29). > > Then this 2 bit field is consistent. > > > Sir, I guess this BIT(29) was already present. I didn't changed this. > I will change this as you said.
It comes from this patch:
5e195bbddabdd94b15eeb60439cece996d58b329
Probably putting it back should be a different patch in the series.
julia
| |