lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/9] kcsan: Add support for reporting observed value changes
On Wed, Apr 14, 2021 at 01:28:16PM +0200, Marco Elver wrote:
> This series adds support for showing observed value changes in reports.
> Several clean up and refactors of KCSAN reporting code are done as a
> pre-requisite.

> This series was originally prepared courtesy of Mark Rutland in
> September 2020.

For anyone looking for the original, it was never posted to a list, but
is sat on my kcsan/rework branch on kernel.org:

https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=kcsan/rework

> Because KCSAN had a few minor changes since the original
> draft of the series, it required a rebase and re-test. To not be
> forgotten and get these changes in sooner than later, Mark kindly agreed
> to me adopting the series and doing the rebase, a few minor tweaks, and
> finally re-test.

Thanks for picking this up!

All your changes look good to me (along with the documentation patch),
so FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

>
> Marco Elver (1):
> kcsan: Document "value changed" line
>
> Mark Rutland (8):
> kcsan: Simplify value change detection
> kcsan: Distinguish kcsan_report() calls
> kcsan: Refactor passing watchpoint/other_info
> kcsan: Fold panic() call into print_report()
> kcsan: Refactor access_info initialization
> kcsan: Remove reporting indirection
> kcsan: Remove kcsan_report_type
> kcsan: Report observed value changes
>
> Documentation/dev-tools/kcsan.rst | 88 +++++++---------
> kernel/kcsan/core.c | 53 ++++------
> kernel/kcsan/kcsan.h | 39 ++++---
> kernel/kcsan/report.c | 169 ++++++++++++++++--------------
> 4 files changed, 162 insertions(+), 187 deletions(-)
>
> --
> 2.31.1.295.g9ea45b61b8-goog
>

\
 
 \ /
  Last update: 2021-04-15 13:48    [W:0.081 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site