Messages in this thread | | | Date | Thu, 15 Apr 2021 10:46:50 +0000 | From | Yassine Oudjana <> | Subject | Re: [PATCH v6 2/4] leds: Add driver for Qualcomm LPG |
| |
Hi,
On Wed, 21 Oct 2020 13:12:22 -0700 Bjorn Andersson wrote: > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > PMICs from Qualcomm. It can operate on fixed parameters or based on a > lookup-table, altering the duty cycle over time - which provides the > means for e.g. hardware assisted transitions of LED brightness. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Changes since v5: > - Make sure to not used the state of the last channel in a group to > determine if the current sink should be active for all channels in the > group. - Replacement of unsigned -1 with UINT_MAX > - Work around potential overflow by using larger data types, instead of > separate code paths - Use cpu_to_l16() rather than hand rolling them > - Minor style cleanups > > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-qcom-lpg.c | 1190 ++++++++++++++++++++++++++++++++++ > 3 files changed, 1200 insertions(+) > create mode 100644 drivers/leds/leds-qcom-lpg.c
Works well on the Xiaomi Mi Note 2 (msm8996pro/pmi8996).
Tested-by: Yassine Oudjana <y.oudjana@protonmail.com>
Regards, Yassine
| |