Messages in this thread | | | Date | Thu, 15 Apr 2021 12:54:22 +0200 | From | Boris Kolpackov <> | Subject | Re: [PATCH] kconfig: split menu.c out of parser.y |
| |
Masahiro Yamada <masahiroy@kernel.org> writes:
> --- /dev/null > +++ b/scripts/kconfig/internal.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef INTERNAL_H > +#define INTERNAL_H > + > +struct menu; > + > +extern struct menu *current_menu, *current_entry; > + > +#endif /* INTERNAL_H */
Maybe call it menu.h instead of internal.h? Unless you have plans to put other "internal" stuff in there.
> --- a/scripts/kconfig/parser.y > +++ b/scripts/kconfig/parser.y > @@ -28,7 +29,7 @@ static bool zconf_endtoken(const char *tokenname, > > struct symbol *symbol_hash[SYMBOL_HASHSIZE]; > > -static struct menu *current_menu, *current_entry; > +struct menu *current_menu, *current_entry;
Why not put these in menu.c?
| |