lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 48/57] staging: comedi: drivers: jr3_pci: Remove set but unused variable 'min_full_scale'
    From
    Date
    On 14/04/2021 19:11, Lee Jones wrote:
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/staging/comedi/drivers/jr3_pci.c: In function ‘jr3_pci_poll_subdevice’:
    > drivers/staging/comedi/drivers/jr3_pci.c:507:22: warning: variable ‘min_full_scale’ set but not used [-Wunused-but-set-variable]
    >
    > Cc: Ian Abbott <abbotti@mev.co.uk>
    > Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: "Alexander A. Klimov" <grandmaster@al2klimov.de>
    > Cc: Anders Blomdell <anders.blomdell@control.lth.se>
    > Cc: linux-staging@lists.linux.dev
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/staging/comedi/drivers/jr3_pci.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
    > index 7a02c4fa3cda8..afa2f8d5c8c0c 100644
    > --- a/drivers/staging/comedi/drivers/jr3_pci.c
    > +++ b/drivers/staging/comedi/drivers/jr3_pci.c
    > @@ -504,10 +504,9 @@ jr3_pci_poll_subdevice(struct comedi_subdevice *s)
    > result = poll_delay_min_max(20, 100);
    > } else {
    > /* Set full scale */
    > - struct six_axis_t min_full_scale;
    > struct six_axis_t max_full_scale;
    >
    > - min_full_scale = get_min_full_scales(sensor);
    > + get_min_full_scales(sensor);
    > max_full_scale = get_max_full_scales(sensor);
    > set_full_scales(sensor, max_full_scale);
    >
    >

    get_min_full_scales() could be removed altogether. It was only being
    called originally so the driver could printk the values, but those
    printks have since been removed.

    --
    -=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
    -=( registered in England & Wales. Regd. number: 02862268. )=-
    -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
    -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

    \
     
     \ /
      Last update: 2021-04-15 11:35    [W:4.105 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site