Messages in this thread | | | Subject | Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver | From | Jie Deng <> | Date | Thu, 15 Apr 2021 16:15:07 +0800 |
| |
On 2021/4/15 15:28, Wolfram Sang wrote:
>> Now that we were able to catch you, I will use the opportunity to >> clarify the doubts I had. >> >> - struct mutex lock in struct virtio_i2c, I don't think this is >> required since the core takes care of locking in absence of this. > This is likely correct.
OK. Then I will remove the lock.
>> - Use of I2C_CLASS_DEPRECATED flag, I don't think it is required for >> new drivers. > This is definately correct :)
Do you mean a new driver doesn't need to set the following ?
vi->adap.class = I2C_CLASS_DEPRECATED;
Just leave the class to be 0 ?
> > Let's see if I will have more questions...
OK. Thank you.
| |