Messages in this thread | | | Date | Thu, 15 Apr 2021 08:53:35 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch |
| |
On Wed, Apr 14, 2021 at 05:11:11PM -0700, Nathan Chancellor wrote: > dev_attr_show() calls _iommu_event_show() via an indirect call but > _iommu_event_show()'s type does not currently match the type of the > show() member in 'struct device_attribute', resulting in a Control Flow > Integrity violation.
While the fix looks fine I think we need to solve this kind of problem by better type checking. The fact that we can use the wong type here without a compiler warning is the real issue.
| |