Messages in this thread Patch in this message | | | From | zhuguangqing83@gmail ... | Subject | [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler | Date | Fri, 16 Apr 2021 11:47:12 +0800 |
| |
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Coccinelle noticed: drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com> --- drivers/regulator/mt6360-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c index 4d34be94d166..34c354721ef0 100644 --- a/drivers/regulator/mt6360-regulator.c +++ b/drivers/regulator/mt6360-regulator.c @@ -383,8 +383,8 @@ static int mt6360_regulator_irq_register(struct platform_device *pdev, if (irq < 0) return irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, 0, - irq_desc->name, rdev); + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, + IRQF_ONESHOT, irq_desc->name, rdev); if (ret) { dev_err(&pdev->dev, "Fail to request %s irq\n", irq_desc->name); return ret; -- 2.17.1
| |