lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 net-next 08/10] net: korina: Get mdio input clock via common clock framework
    > @@ -1079,6 +1078,14 @@ static int korina_probe(struct platform_device *pdev)
    > eth_hw_addr_random(dev);
    > }
    >
    > + clk = devm_clk_get(&pdev->dev, NULL);

    You should use a name here. It makes future expansion of the binding
    easier. devm_clk_get_optional() is probably better. If there is a real
    error it will return an error. If the clock does not exist, you get a
    NULL. Real errors should cause the problem to fail, but with a NULL
    you can use the fallback value.

    You also need to document the device tree binding.

    Andrew

    \
     
     \ /
      Last update: 2021-04-16 01:55    [W:4.217 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site