lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 net-next 01/10] net: korina: Fix MDIO functions
> +static int korina_mdio_wait(struct korina_private *lp)
> +{
> + u32 value;
> +
> + return readl_poll_timeout_atomic(&lp->eth_regs->miimind,
> + value, value & ETH_MII_IND_BSY,
> + 1, 1000);
> +}
> +
> +static int korina_mdio_read(struct net_device *dev, int phy, int reg)
> {
> struct korina_private *lp = netdev_priv(dev);
> int ret;
>
> - mii_id = ((lp->rx_irq == 0x2c ? 1 : 0) << 8);
> + if (korina_mdio_wait(lp))
> + return -ETIMEDOUT;
>
> - writel(0, &lp->eth_regs->miimcfg);
> - writel(0, &lp->eth_regs->miimcmd);
> - writel(mii_id | reg, &lp->eth_regs->miimaddr);
> - writel(ETH_MII_CMD_SCN, &lp->eth_regs->miimcmd);
> + writel(phy << 8 | reg, &lp->eth_regs->miimaddr);
> + writel(1, &lp->eth_regs->miimcmd);
> +
> + if (korina_mdio_wait(lp))
> + return -ETIMEDOUT;

Just return what readl_poll_timeout_atomic() returns. In general, you
should not change error codes.

>
> - ret = (int)(readl(&lp->eth_regs->miimrdd));
> + if (readl(&lp->eth_regs->miimind) & ETH_MII_IND_NV)
> + return -1;

Please use -ESOMETHING, not -1.

Andrew

\
 
 \ /
  Last update: 2021-04-16 01:18    [W:0.126 / U:1.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site