lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] KVM: Stop looking for coalesced MMIO zones if the bus is destroyed
    On Mon, Apr 12, 2021 at 3:21 PM Sean Christopherson <seanjc@google.com> wrote:
    >
    > Abort the walk of coalesced MMIO zones if kvm_io_bus_unregister_dev()
    > fails to allocate memory for the new instance of the bus. If it can't
    > instantiate a new bus, unregister_dev() destroys all devices _except_ the
    > target device. But, it doesn't tell the caller that it obliterated the
    > bus and invoked the destructor for all devices that were on the bus. In
    > the coalesced MMIO case, this can result in a deleted list entry
    > dereference due to attempting to continue iterating on coalesced_zones
    > after future entries (in the walk) have been deleted.
    >
    > Opportunistically add curly braces to the for-loop, which encompasses
    > many lines but sneaks by without braces due to the guts being a single
    > if statement.
    >
    > Fixes: f65886606c2d ("KVM: fix memory leak in kvm_io_bus_unregister_dev()")
    > Cc: stable@vger.kernel.org
    > Reported-by: Hao Sun <sunhao.th@gmail.com>
    > Signed-off-by: Sean Christopherson <seanjc@google.com>
    Reviewed-by: Jim Mattson <jmattson@google.com>

    \
     
     \ /
      Last update: 2021-04-16 00:24    [W:2.932 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site