lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
On Thu, Apr 15, 2021 at 08:19:46PM +0530, Aswath Govindraju wrote:
> Add binding documentation for TI TCAN104x CAN transceivers.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> new file mode 100644
> index 000000000000..4643b979930a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TCAN104x CAN TRANSCEIVER PHY
> +
> +maintainers:
> + - Aswath Govindraju <a-govindraju@ti.com>
> +
> +properties:
> + $nodename:
> + pattern: "^tcan104x-phy"

Node names should be generic. So 'phy' or 'can-phy'.

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> + compatible:
> + enum:
> + - ti,tcan1042
> + - ti,tcan1043
> +
> + '#phy-cells':
> + const: 0
> +
> + standby-gpios:
> + description:
> + gpio node to toggle standby signal on transceiver
> + maxItems: 1
> +
> + enable-gpios:
> + description:
> + gpio node to toggle enable signal on transceiver
> + maxItems: 1
> +
> + max-bitrate:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + max bit rate supported in bps
> + minimum: 1
> +
> +required:
> + - compatible
> + - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + transceiver1: tcan104x-phy {
> + compatible = "ti,tcan1043";
> + #phy-cells = <0>;
> + max-bitrate = <5000000>;
> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_HIGH>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84ef96a444c3..e666d33af10d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4046,6 +4046,7 @@ W: https://github.com/linux-can
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
> F: Documentation/devicetree/bindings/net/can/
> +F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> F: drivers/net/can/
> F: include/linux/can/bittiming.h
> F: include/linux/can/dev.h
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2021-04-15 23:13    [W:0.080 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site