lkml.org 
[lkml]   [2021]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 44/57] staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed functions
    Date
    ... and fix a misnamed param.

    Fixes the following W=1 kernel build warning(s):

    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:53: warning: expecting prototype for PHY_QueryBBReg(). Prototype was for PHY_QueryBBReg_8723B() instead
    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:87: warning: expecting prototype for PHY_SetBBReg(). Prototype was for PHY_SetBBReg_8723B() instead
    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:252: warning: Function parameter or member 'RegAddr' not described in 'PHY_QueryRFReg_8723B'
    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:252: warning: expecting prototype for PHY_QueryRFReg(). Prototype was for PHY_QueryRFReg_8723B() instead
    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:285: warning: expecting prototype for PHY_SetRFReg(). Prototype was for PHY_SetRFReg_8723B() instead

    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: karthik alapati <mail@karthek.com>
    Cc: linux-staging@lists.linux.dev
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
    index f43abf9b0d225..011b42e1b9917 100644
    --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
    +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
    @@ -38,7 +38,7 @@ static u32 phy_CalculateBitShift(u32 BitMask)


    /**
    - * PHY_QueryBBReg - Read "specific bits" from BB register.
    + * PHY_QueryBBReg_8723B - Read "specific bits" from BB register.
    * @Adapter:
    * @RegAddr: The target address to be readback
    * @BitMask: The target bit position in the target address
    @@ -66,7 +66,7 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 RegAddr, u32 BitMask)


    /**
    - * PHY_SetBBReg - Write "Specific bits" to BB register (page 8~).
    + * PHY_SetBBReg_8723B - Write "Specific bits" to BB register (page 8~).
    * @Adapter:
    * @RegAddr: The target address to be modified
    * @BitMask: The target bit position in the target address
    @@ -231,10 +231,10 @@ static void phy_RFSerialWrite_8723B(


    /**
    - * PHY_QueryRFReg - Query "Specific bits" to RF register (page 8~).
    + * PHY_QueryRFReg_8723B - Query "Specific bits" to RF register (page 8~).
    * @Adapter:
    * @eRFPath: Radio path of A/B/C/D
    - * @RegAdd: The target address to be read
    + * @RegAddr: The target address to be read
    * @BitMask: The target bit position in the target address
    * to be read
    *
    @@ -263,7 +263,7 @@ u32 PHY_QueryRFReg_8723B(
    }

    /**
    - * PHY_SetRFReg - Write "Specific bits" to RF register (page 8~).
    + * PHY_SetRFReg_8723B - Write "Specific bits" to RF register (page 8~).
    * @Adapter:
    * @eRFPath: Radio path of A/B/C/D
    * @RegAddr: The target address to be modified
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-04-14 20:15    [W:4.139 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site