lkml.org 
[lkml]   [2021]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/57] staging: r8192U_core: Remove unused variable 'ret' and demote kernel-doc abuse
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/staging/rtl8192u/r8192U_core.c: In function ‘rtl8192_hard_data_xmit’:
    drivers/staging/rtl8192u/r8192U_core.c:905:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Andrea Merello <andrea.merello@gmail.com>
    Cc: Jerry chuang <wlanfae@realtek.com>
    Cc: linux-staging@lists.linux.dev
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/staging/rtl8192u/r8192U_core.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
    index f48186a89fa14..643769e32e433 100644
    --- a/drivers/staging/rtl8192u/r8192U_core.c
    +++ b/drivers/staging/rtl8192u/r8192U_core.c
    @@ -902,7 +902,6 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
    int rate)
    {
    struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
    - int ret;
    unsigned long flags;
    struct cb_desc *tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
    u8 queue_index = tcb_desc->queue_index;
    @@ -915,7 +914,7 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
    *(struct net_device **)(skb->cb) = dev;
    tcb_desc->bTxEnableFwCalcDur = 1;
    skb_push(skb, priv->ieee80211->tx_headroom);
    - ret = rtl8192_tx(dev, skb);
    + rtl8192_tx(dev, skb);

    spin_unlock_irqrestore(&priv->tx_lock, flags);
    }
    @@ -2972,12 +2971,10 @@ static RESET_TYPE RxCheckStuck(struct net_device *dev)
    return RESET_TYPE_NORESET;
    }

    -/**
    +/*
    * This function is called by Checkforhang to check whether we should
    * ask OS to reset driver
    *
    - * \param pAdapter The adapter context for this miniport
    - *
    * Note:NIC with USB interface sholud not call this function because we
    * cannot scan descriptor to judge whether there is tx stuck.
    * Note: This function may be required to be rewrite for Vista OS.
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-04-14 20:13    [W:4.060 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site