Messages in this thread | | | From | Namhyung Kim <> | Date | Thu, 15 Apr 2021 02:45:17 +0900 | Subject | Re: [PATCH v8 2/4] libperf: Add evsel mmap support |
| |
On Thu, Apr 15, 2021 at 1:53 AM Rob Herring <robh@kernel.org> wrote: > > On Wed, Apr 14, 2021 at 11:41 AM Namhyung Kim <namhyung@kernel.org> wrote: > > > > Hello, > > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring <robh@kernel.org> wrote: > > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread) > > > +{ > > > + if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL) > > > + return NULL; > > > > I think you should check the cpu and the thread is in > > a valid range. Currently xyarray__entry() simply accesses > > the content without checking the boundaries. > > Happy to add a patch to do that if desired, but I think that's > separate from this series. That would be something to add to > xyarray__entry().
Sure, we can do that separately.
Thanks, Namhyung
| |