Messages in this thread | | | Subject | Re: [PATCH v2 2/3] soundwire: Intel: introduce DMI quirks for HP Spectre x360 Convertible | From | Pierre-Louis Bossart <> | Date | Wed, 14 Apr 2021 10:21:48 -0500 |
| |
On 4/13/21 11:08 PM, Vinod Koul wrote: > On 12-04-21, 14:37, Dave Hansen wrote: >> On 3/1/21 11:51 PM, Bard Liao wrote: >>> +++ b/drivers/soundwire/dmi-quirks.c >>> @@ -0,0 +1,66 @@ >>> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) >>> +// Copyright(c) 2021 Intel Corporation. >> >> It looks like this is already in intel-next, so this may be moot. But, >> is there a specific reason this is dual licensed? If so, can you please >> include information about the license choice in the cover letter of any >> future version? > > The soundwire module from Intel and core soundwire core was always dual > licensed, so it kind of followed that.. > >> If there is no specific reason for this contribution to be dual >> licensed, please make it GPL-2.0 only. > > This module, I would say NO. Unless someone from Intel disagree.. > Pierre/Bard..? > > If all agree I dont see a reason why this cant be updated to GPL only.
The initial version of those quirks was contributed as a change to drivers/soundwire/slave.c, which is dual-licensed. the code was split to a different file and the dual-license followed.
I am personally favorable to keeping the code as is, the quirks are just referring to low-level hardware descriptors that are not aligned with DevID hardware registers in external SoundWire devices. If enumeration was handled at a lower level, e.g. in DSP firmware the same information would be quite useful.
That said, it's been agreed with Dave that moving forward all new contributions from Intel with a dual-license would include an explicit statement in the commit message as to why it was selected over plain vanilla GPL-2.0-only.
| |