Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 14 Apr 2021 08:28:49 -0700 | Subject | Re: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset |
| |
Hi,
On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang <johnny.chuang.emc@gmail.com> wrote: > > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset").
Note that the "Fixes" tag actually belongs down at the end. It also shouldn't have a "." at the end. Presumably the maintainer can adjust this when landing?
> For ELAN touchscreen, we found our boot code of IC was not flexible enough > to receive and handle this command. > Once the FW main code of our controller is crashed for some reason, > the controller could not be enumerated successfully to be recognized > by the system host. therefore, it lost touch functionality. > > Add quirk for skip send power-on command after reset. > It will impact to ELAN touchscreen and touchpad on HID over I2C projects. > > Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
This patch looks fine to me, thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I can confirm that after applying this patch I can recovery my borked touchscreen (which got borked by a failed firmware update ages ago):
Tested-by: Douglas Anderson <dianders@chromium.org>
| |