Messages in this thread | | | Date | Wed, 14 Apr 2021 10:01:29 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH v4 2/2] remoteproc: stm32: add capability to detach |
| |
On Wed 14 Apr 02:23 CDT 2021, Arnaud POULIQUEN wrote: > On 4/13/21 11:34 PM, Bjorn Andersson wrote: > > On Wed 31 Mar 02:33 CDT 2021, Arnaud Pouliquen wrote: [..] > >> + err = mbox_send_message(ddata->mb[idx].chan, > >> + &dummy_data); > > > > Seems I posted my comment on v1, rather than this latest version. Please > > let me know if we should do anything about this dummy_data. > > Thanks for pointing this out, you are right, the mailbox driver is stm32_ipcc > and it only sends a signal to the remote processor. > > As message can be queued by the mailbox framework using a local variable seems > not a good option. As this code is a copy/past of the kick and stop? > I propose to get this one and I will send a new patch to fix the usage in the > whole driver. >
That works for me, I've merged the two patches.
Thanks, Bjorn
| |