Messages in this thread Patch in this message | | | From | Neil Armstrong <> | Subject | [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode | Date | Wed, 14 Apr 2021 12:00:10 +0200 |
| |
Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode"), support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some driver like brcmfmac still gives a block sg buffer size not aligned with SDIO block, triggerring a warning even if the transfer works in degraded mode.
This should be ultimately fixed in brcmfmac, but since it's only a performance issue the warning should be removed.
Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode") Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/mmc/host/meson-gx-mmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index eb6c02bc4a02..6bc151045843 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -246,11 +246,8 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc, * size, otherwise chain mode could not be used. */ for_each_sg(data->sg, sg, data->sg_len, i) { - if (sg->length % data->blksz) { - WARN_ONCE(1, "unaligned sg len %u blksize %u\n", - sg->length, data->blksz); + if (sg->length % data->blksz) return; - } } } -- 2.25.1
| |