Messages in this thread | | | From | Matthieu Baerts <> | Subject | Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard | Date | Wed, 14 Apr 2021 11:25:03 +0200 |
| |
Hi Nico,
On 14/04/2021 10:58, Nico Pache wrote: > Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the > KUNIT *_KUNIT_TEST config name format.
For MPTCP, we have multiple KUnit tests: crypto and token. That's why we wrote TESTS with a S.
I'm fine without S if we need to stick with KUnit' standard. But maybe the standard wants us to split the two tests and create MPTCP_TOKEN_KUNIT_TEST and MPTCP_TOKEN_KUNIT_TEST config?
In this case, we could eventually keep MPTCP_KUNIT_TESTS which will in charge of selecting the two new ones.
Up to the KUnit maintainers to decide ;-)
Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
| |