lkml.org 
[lkml]   [2021]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v18 4/5] misc: eeprom: at24: check suspend status before disable regulator
    Date
    cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables
    regulator in runtime suspend. If runtime suspend is called before
    regulator disable, it will results in regulator unbalanced disabling.

    Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
    ---
    drivers/misc/eeprom/at24.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
    index 926408b41270..7a6f01ace78a 100644
    --- a/drivers/misc/eeprom/at24.c
    +++ b/drivers/misc/eeprom/at24.c
    @@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client)
    at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
    if (IS_ERR(at24->nvmem)) {
    pm_runtime_disable(dev);
    - regulator_disable(at24->vcc_reg);
    + if (!pm_runtime_status_suspended(dev))
    + regulator_disable(at24->vcc_reg);
    return PTR_ERR(at24->nvmem);
    }

    @@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client)
    err = at24_read(at24, 0, &test_byte, 1);
    if (err) {
    pm_runtime_disable(dev);
    - regulator_disable(at24->vcc_reg);
    + if (!pm_runtime_status_suspended(dev))
    + regulator_disable(at24->vcc_reg);
    return -ENODEV;
    }

    --
    2.31.1.295.g9ea45b61b8-goog
    \
     
     \ /
      Last update: 2021-04-14 10:40    [W:4.648 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site