Messages in this thread Patch in this message | | | Date | Wed, 14 Apr 2021 10:55:25 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal |
| |
On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > Added a generic function of static inline bool in > include/linux/etherdevice.h to replace memcmp with > ether_oui_equal throughout the execution. > Corrected the misspelled words in this file. > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> > --- > > Changes from v1:- Rectified spelling mistake and replaced memcmp with > ether_oui_equal. > > drivers/staging/rtl8192e/rtl819x_HTProc.c | 48 +++++++++++------------ > include/linux/etherdevice.h | 5 +++ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ This is networking code and not staging code, but the netdev mailing list isn't CC'd.
> 2 files changed, 29 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c > index ec6b46166e84..ce58feb2af9a 100644 > --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c > @@ -43,7 +43,7 @@ u16 MCS_DATA_RATE[2][2][77] = { > 810, 720, 810, 900, 900, 990} } > }; > > -static u8 UNKNOWN_BORADCOM[3] = {0x00, 0x14, 0xbf}; > +static u8 UNKNOWN_BROADCOM[3] = {0x00, 0x14, 0xbf};
Please pull this spelling fix into its own patch.
[ snip ]
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h > index 2e5debc0373c..6a1a63168319 100644 > --- a/include/linux/etherdevice.h > +++ b/include/linux/etherdevice.h > @@ -87,6 +87,11 @@ static inline bool is_link_local_ether_addr(const u8 *addr) > #endif > } > > +static inline bool ether_oui_equal(const u8 *addr, const u8 *oui) > +{ > +return addr[0] == oui[0] && addr[1] == oui[1] && addr[2] == oui[2]; > +}
The indenting is messed up on this.
regards, dan carpenter
| |