Messages in this thread | | | Subject | Re: [PATCH] Fix turbostat exiting with an error when run on AMD CPUs | From | Calvin Walton <> | Date | Wed, 14 Apr 2021 22:25:58 -0400 |
| |
On Thu, 2021-04-15 at 10:26 +0800, Chen Yu wrote: > Hi Calvin, > On Wed, Apr 14, 2021 at 10:08:07PM -0400, Calvin Walton wrote: > > On Wed, 2021-04-14 at 22:05 -0400, Calvin Walton wrote: > > > The current version of turbostat exits immediately upon entering > > > the > > > main loop, with error code -13. This is a regression that was > > > introducted > > > in these commits: > > > > > > 9972d5d84d76 tools/power turbostat: Enable accumulate RAPL > > > display > > > 87e15da95775 tools/power turbostat: Introduce functions to > > > accumulate > > > RAPL consumption > > > > Ah, I failed to check the mailing list before sending this patch! > > Terry > > Bowman's fix here should probably be preferred: > > https://patchwork.kernel.org/project/linux-pm/patch/20210331155807.3838-1-terry.bowman@amd.com/ > > > > My patch was simply the minimum necessary to get turbostat working > > again. > Thanks for reporting this. We had a fix for this previously at > https://lkml.org/lkml/2021/3/12/682 > > I'll check with Len if this patch has been merged.
Thanks for checking.
I notice that the linked patch doesn't include the other part of the fix - correcting the type used for the MSR offsets to off_t (the AMD MSRs at 0xc0010299 exceed the range of a signed 32-bit int), so if that patch is in the queue to be merged, I can submit the off_t patch separately.
-- Calvin Walton <calvin.walton@kepstin.ca>
| |