lkml.org 
[lkml]   [2021]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const
On Wed, 14 Apr 2021, Andy Shevchenko wrote:

> On Wed, Apr 14, 2021 at 06:13:19PM +0100, Lee Jones wrote:
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> >
> > > On Fri, 26 Mar 2021, Andy Shevchenko wrote:
> > >
> > > > As Linus rightfully noticed, the driver plays dirty trick with const,
> > > > i.e. it assigns a place holder data structure to the const field
> > > > in the MFD cell and then drops the const by explicit casting. This is
> > > > not how it should be.
> > > >
> > > > Assign local pointers of the cell and resource to the respective
> > > > non-const place holders in the intel_quark_i2c_setup() and
> > > > intel_quark_gpio_setup().
> > > >
> > > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > v2: eliminated bar parameter (Lee)
> > > > drivers/mfd/intel_quark_i2c_gpio.c | 26 ++++++++++++--------------
> > > > 1 file changed, 12 insertions(+), 14 deletions(-)
> > >
> > > Neat.
> > >
> > > Applied, thanks.
> >
> > Am I still missing patches from you Andy?
>
> Patches for fixes should be applied to for-next as well. I don't know why with
> my patches it diverged.
>
> I have already commented on this when kbuild bot complained.
>
> So,
>
> git checkout for-mfd-next
> git merge for-mfd-fixes
>
> or equivalent (cherry-pick) will fix that.

Ah, it's in -rc5. Very good. Thanks for the explanation.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2021-04-14 23:21    [W:0.070 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site