Messages in this thread | | | Date | Wed, 14 Apr 2021 14:46:54 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v10 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER |
| |
On Sat, Apr 10, 2021 at 01:22:18AM +0900, Kunihiko Hayashi wrote: > This patch adds misc interrupt handler to detect and invoke PME/AER event. > > In UniPhier PCIe controller, PME/AER signals are assigned to the same > signal as MSI by the internal logic. These signals should be detected by > the internal register, however, DWC MSI handler can't handle these signals. > > DWC MSI handler calls .msi_host_isr() callback function, that detects > PME/AER signals using the internal register and invokes the interrupt > with PME/AER vIRQ numbers. > > These vIRQ numbers is obtained by uniphier_pcie_port_get_irq() function, > that finds the device that matches PME/AER from the devices associated > with Root Port, and returns its vIRQ number.
Why do you use the term "vIRQ"? What exactly is a vIRQ? It seems no different than the simple "irq" as stored in pci_dev.irq or pcie_device.irq and passed to generic_handle_irq(). "virq" is also used in the patch, so if you change one, please change the other as well.
Bjorn
| |