Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 14 Apr 2021 20:55:21 +0200 | Subject | Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI |
| |
Hi Andy,
On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang <yangyicong@hisilicon.com> wrote: > > > On 2021/4/13 20:26, Geert Uytterhoeven wrote: > > > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > > > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > > > > about this driver when configuring a kernel without Hisilicon platform > > > > or ACPI firmware support. > > > > > > this is a public IP which doesn't specifically depend on ARCH_HISI. I'm > > > not sure all the platform this IP on has ARCH_HISI configured. The driver > > > will not be compiled by default config. This is not correct to have > > > this dependence. > > > > Thanks for your answer! > > > > I guess it's still fine to add a dependency on ACPI? > > But why?
Please tell me how/when the driver is used when CONFIG_ACPI=n. Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |