Messages in this thread | | | From | Florent Revest <> | Date | Wed, 14 Apr 2021 20:30:29 +0200 | Subject | Re: [PATCH bpf-next v3 3/6] bpf: Add a bpf_snprintf helper |
| |
Hey Geert! :)
On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko > <andrii.nakryiko@gmail.com> wrote: > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest <revest@chromium.org> wrote: > > > + fmt = (char *)fmt_addr + fmt_map_off; > > > + > > > > bot complained about lack of (long) cast before fmt_addr, please address > > (uintptr_t), I assume?
(uintptr_t) seems more correct to me as well. However, I just had a look at the rest of verifier.c and (long) casts are already used pretty much everywhere whereas uintptr_t isn't used yet. I'll send a v4 with a long cast for the sake of consistency with the rest of the verifier.
| |